With Goodnotes 6 being released, it now is a subscription instead of a flat payment. I am looking for a replacement app that is not subscription based. I have tried onenote and really did not care for it. Notability is one that i have seen suggested, use it a single payment?
If your notes are primarily text, I’d suggest Obsidian. It’s cross-platform (Mac, Windows, iOS, Android, and Linux) and open source. I moved over from OneNote and have been absolutely loving it.