I’m talking about stuff like this: [file.unlink() for file in files] instead of the more verbose but maybe easier to grasp for python noobs:

for file in files:
    file.unlink()

Maybe with a bit more context:

def _cleanup(self) -> None:                                                                                                                                                                                                             
    dirs, files = partition(lambda f: f.is_file(), self._tmp_dir.rglob("*"))                                                                                                                                                            
    [file.unlink() for file in files]                                                                                                                                                                                                   
    [dir.rmdir() for dir in dirs]                                                                                                                                                                                                       
    self._tmp_dir.rmdir()
  • psukys@feddit.de
    link
    fedilink
    arrow-up
    3
    ·
    1 year ago

    Typically I would expect for list comprehension to be used for data generation or filtering, so something like this definitely strikes odd when reading code and would just ask to unpack into classic loop

  • nieceandtows@programming.dev
    link
    fedilink
    arrow-up
    1
    ·
    1 year ago

    I don’t think this is a good place to use list comprehension. Yes the code is smaller, but it is very hacky. It’s like those flight booking hacks where you book for a different destination with your actual destination as a transit location. Yes it’s cheaper, but that’s not an elegant solution.